ENH: consistently cast strings for DTA/TDA/PA.__setitem__ #36261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
|
I guess this is technically a bug fix on DTA, maybe add a note; ping on green. |
…ify-validators-cast_str
|
ping |
|
thoughts on if we want to support this in Series.setitem etc? that's pretty easy, just define DatetimeLikeBlock._can_hold_element to wrap DatetimeLikeArray._validate_setitem_value xref #36226 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…#36261) * ENH: consistently cast strings for DTA/TDA/PA.__setitem__ * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM we cast strings for listlike inputs but not for scalars.